Skip to content

fix: memento format migration #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2025
Merged

fix: memento format migration #957

merged 1 commit into from
Jun 3, 2025

Conversation

gfyrag
Copy link
Contributor

@gfyrag gfyrag commented Jun 3, 2025

No description provided.

@gfyrag gfyrag requested a review from a team as a code owner June 3, 2025 08:05
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jun 3, 2025 •
edited
Loading

Walkthrough

The SQL migration script was updated to modify how targetType and targetId are extracted from the logs.data JSON column in the SET_METADATA case, switching from text extraction to direct JSON object access. A trailing newline at the end of the file was also removed.

Changes

File(s) Change Summary
internal/storage/bucket/migrations/34-fix-memento-format/up.sql Modified JSON extraction for targetType and targetId in a conditional; removed trailing newline

Sequence Diagram(s)

sequenceDiagram
    participant SQL_Migration
    participant Logs_Table
    participant JSON_Data

    SQL_Migration->>Logs_Table: SELECT logs.data
    Logs_Table-->>SQL_Migration: Return JSON column
    SQL_Migration->>JSON_Data: Extract targetType and targetId as JSON (using ->)
    JSON_Data-->>SQL_Migration: Return targetType, targetId
Loading

Possibly related PRs

  • fix: memento format #926: Updates the same migration script and logic for reconstructing the memento JSON format, indicating a direct connection.

Suggested reviewers

  • paul-nicolas

Poem

In the land of SQL, where queries roam free,
A rabbit hops in, as clever as can be.
With JSON now fetched, not as text but as whole,
The memento is fixed—onward toward the goal!
🐇✨

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 56a0090 and 2c5bf59.

📒 Files selected for processing (1)
  • internal/storage/bucket/migrations/34-fix-memento-format/up.sql (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Dirty
  • GitHub Check: Tests
🔇 Additional comments (1)
internal/storage/bucket/migrations/34-fix-memento-format/up.sql (1)

52-53: Preserve JSON structure in SET_METADATA migration.

Switching from ->> to -> for targetType and targetId avoids unnecessary text extraction and casting, maintaining the native JSON types. Confirm that downstream consumers expect JSON values—if they require plain strings or numeric values, consider using ->> (and casting) instead.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov Codecov
Copy link

codecov bot commented Jun 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.42%. Comparing base (56a0090) to head (2c5bf59).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #957   +/-   ##
=======================================
  Coverage   82.42%   82.42%           
=======================================
  Files         141      141           
  Lines        7835     7835           
=======================================
  Hits         6458     6458           
  Misses       1054     1054           
  Partials      323      323

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gfyrag gfyrag added this pull request to the merge queue Jun 3, 2025
Merged via the queue into main with commit c7dd5c2 Jun 3, 2025
10 checks passed
@gfyrag gfyrag deleted the fix/fix-memento-format-migration branch June 3, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flemzord flemzord flemzord approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gfyrag @flemzord